VkFFT icon indicating copy to clipboard operation
VkFFT copied to clipboard

Use enum for vendor ID

Open davebayer opened this issue 1 year ago • 2 comments

This pull request introduces VkFFTVendor enum datatype for vendor id instead of using magic values.

davebayer avatar Mar 09 '24 20:03 davebayer

Hello,

Thank you for the change, it will also make the code more clear. It missed the 0x1027f00 Apple vendor ID definition and I am not sure yet whether the casting of vendor IDs returned by different APIs to the enum will trigger any warnings (in Vulkan I believe it to be an unsigned integer).

Best regards, Dmitrii

DTolm avatar Mar 22 '24 14:03 DTolm

Hi,

I have fixed the casts from different types and added VKFFT_VENDOR_APPLE to the enum. I am sorry, I overlooked it completely.

Best regards, David

davebayer avatar Mar 22 '24 14:03 davebayer