chunjun icon indicating copy to clipboard operation
chunjun copied to clipboard

[Bug][chunjun-connectors] jdbc's properties not work where jdbc's reader has set properties

Open AliceXiaoLu opened this issue 2 years ago • 2 comments

Purpose of this pull request

Which issue you fix

Fixes # (issue).

Checklist:

  • [x] I have executed the 'mvn spotless:apply' command to format my code.
  • [ ] I have a meaningful commit message (including the issue id, the template of commit message is '[label-type-#issue-id][fixed-module] a meaningful commit message.')
  • [x] I have performed a self-review of my own code.
  • [ ] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have made corresponding changes to the documentation.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [ ] New and existing unit tests pass locally with my changes.
  • [ ] I have checked my code and corrected any misspellings.
  • [ ] My commit is only one. (If there are multiple commits, you can use 'git squash' to compress multiple commits into one.)

AliceXiaoLu avatar Feb 18 '24 03:02 AliceXiaoLu

@zoudaokoulife @libailin Please help to review it

AliceXiaoLu avatar Feb 18 '24 03:02 AliceXiaoLu

@AliceXiaoLu 当前提交中包含其他的commit ,merge rebase 失败,请基于mater 分支重新修复提交一个pr. image

zoudaokoulife avatar Feb 21 '24 02:02 zoudaokoulife