dspace-angular
dspace-angular copied to clipboard
Resolving item version page routing by using config `nameSpace` #4358
References
- Fixes #4358 – More context found here
Description
I included a way for Angular to retrieve the namespace from the configuration file, enabling users to traverse to the newest version of an item in a way that includes the site's subpath.
Instructions for Reviewers
- Injects the frontend configuration into
src/app/item-page/versions/notice/item-versions-notice.component.tsto useui.nameSpacewithgetItemPageRoute(). - Changed
src/app/item-page/item-page-routing-paths.tsto includeui.nameSpacebefore the full item subpath when moving across item versions via the providedherelink. - 🚨 Crucial! Setting DSpace to a subpath requires configuring
server.servlet.context-pathat least inlocal.cfge.g. in our caseserver.servlet.context-path=/metadata/server. I couldn't find this in the documentation; we discovered this by looking at[dspace]/webapps/server/WEB-INF/classes/application.properties.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome). However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
- [x] My PR is created against the
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch). - [x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
- [x] My PR passes ESLint validation using
npm run lint - [x] My PR doesn't introduce circular dependencies (verified via
npm run check-circ-deps) - [x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
- [x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
- [x] My PR aligns with Accessibility guidelines if it makes changes to the user interface.
- [x] My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
- [x] My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
- [x] If my PR includes new libraries/dependencies (in
package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation. - [x] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
- [x] If my PR fixes an issue ticket, I've linked them together.