dspace-angular icon indicating copy to clipboard operation
dspace-angular copied to clipboard

Fix navbar wrapping on medium screens

Open AndreaBarbasso opened this issue 1 year ago • 0 comments

References

  • Fixes #3512

Description

Removed a white-space: nowrap rule, added some flex-shrink and flex-grow classes, and removed a flex-wrap class so that the navbar is not wrapping anymore on two lines.

Instructions for Reviewers

As said on #3512, on medium-sized screens the navbar could wrap on another row if there were more than 3 items in it. This PR introduces some template and style changes to avoid this behavior.

List of changes in this PR:

  • Removed a white-space: nowrap; rule` that was wrapping the navbar onto another row;
  • Added rules so that the navbar items could break on multiple rows and avoid overflowing of the right-hand side action buttons.

To reproduce the issue you can simply duplicate a navbar item and resize the screen. With this PR there is no wrapping or overflowing of items.

image

Checklist

  • [x] My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • [x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • [x] My PR passes ESLint validation using npm run lint
  • [x] My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • [x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • [x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • [x] My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • [x] My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • [x] My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • [x] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • [x] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • [x] If my PR fixes an issue ticket, I've linked them together.

AndreaBarbasso avatar Oct 22 '24 13:10 AndreaBarbasso