dspace-angular icon indicating copy to clipboard operation
dspace-angular copied to clipboard

Changing the bitstream title in the submission form to use the view c…

Open DanGastardelli opened this issue 1 year ago • 1 comments
trafficstars

…omponent title, avoiding disappearance with changes to the form

References

  • Fixes #3291

Description

The "fileName" variable was removed from the upload "step" and the bitstream visualization component was used to display the title and thus prevent it from disappearing when the form is changed.

Instructions for Reviewers

Install this frontend connected to the demo backend or a clean backend and test the submission in a publishing entity that has a form that links metadata to another entity with the search modal active (different from the "suggest" mode). In this submission, you must initially upload the file, check if the file title appears correctly and then open the modal and select the entity to be linked (whether author, advisor, journal...). Note that after this the bistream title remains intact, correcting the problem reported where the title disappeared.

List of changes in this PR:

  • Removing original line 21 from the file "src/app/submission/sections/upload/file/section-upload-file.component.html" and replacing it with the import of the "ds-submission-section-upload-file-view" view component; removing this same call from line 46 of the same file.

  • In the "src/app/submission/sections/upload/file/view/section-upload-file-view.component.html" view component, the title size was changed from "h5" to "h3" as it was in the previous title and the "span" was included, taking into account the size of the file being processed.

  • Inserting the "FileSizePipe" call in the "src/app/submission/sections/upload/file/view/section-upload-file-view.component.ts" component so that it is possible to process the viewing of the submitted file.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome). However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • [ ] My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • [ ] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • [ ] My PR passes ESLint validation using npm run lint
  • [ ] My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • [ ] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • [ ] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • [ ] My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • [ ] My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • [ ] My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • [ ] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • [ ] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • [ ] If my PR fixes an issue ticket, I've linked them together.

DanGastardelli avatar Oct 01 '24 20:10 DanGastardelli