dspace-angular
dspace-angular copied to clipboard
Add orcid icon with tooltip
References
-
Fixes https://github.com/DSpace/DSpace/issues/9086
-
dspace-8_x version: https://github.com/DSpace/dspace-angular/pull/3345
-
dspace-7_x version: https://github.com/DSpace/dspace-angular/pull/3346
Description
A new component has been created and added to the ds-person-item-metadata-list-element component template. This component shows the ORCID logo and a tooltip on hovering shows the ORCID of the person.
Instructions for Reviewers
You can see the ORCID logo in a Publication page with authors listed.
In order to show the ORCID logo, an author should have at least the person.identifier.orcid metadata set. In this case, the logo is shown with a greyscale filter and a tooltip shows the ORCID with an (unconfirmed) clause.
If the author also has the dspace.orcid.authenticated metadata value, the logo is shown in full color and the tooltip has no (unconfirmed) clause.
List of changes in this PR:
- Created
orcid-badge-and-tooltipcomponent; - Included said component in the
ds-person-item-metadata-list-elementcomponent template;
Checklist
- [x] My PR is created against the
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch). - [x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
- [x] My PR passes ESLint validation using
npm run lint - [x] My PR doesn't introduce circular dependencies (verified via
npm run check-circ-deps) - [x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
- [x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
- [x] My PR aligns with Accessibility guidelines if it makes changes to the user interface.
- [x] My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
- [x] My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
- [x] If my PR includes new libraries/dependencies (in
package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation. - [x] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
- [x] If my PR fixes an issue ticket, I've linked them together.