dspace-angular icon indicating copy to clipboard operation
dspace-angular copied to clipboard

[Port dspace-7_x] Orcid Authorization / Synchronization Page Fixes

Open vins01-4science opened this issue 1 year ago • 1 comments
trafficstars

Please note that this development has been funded by the ORCID Global Participation Fund.


DSpace 8 version here: #31818

References

Description

This PR solves various issues related to the orcid synchronization feature (those issues were related to the stale status of a request saved inside the cache). The full list of issues can be found here: #8925.

Instructions for Reviewers

You should check the behavior of the synchronization page, as suggested inside the issue #8925. Moreover, you should check that the code parameter of the URL is cleared once the account has been connected successfully by using the proper button (Connect to Orcid)

List of changes in this PR:

  • Introduces reactive states derived from item inside orcid-sync page
  • Removes unnecessary navigation
  • Introduces catchError operator and handles failures with error messages

Checklist

  • [x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • [x] My PR passes ESLint validation using yarn lint
  • [x] My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • [x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • [x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • [x] My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • [x] My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • [x] My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • [x] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • [x] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • [x] If my PR fixes an issue ticket, I've linked them together.

vins01-4science avatar Jul 11 '24 13:07 vins01-4science