dspace-angular icon indicating copy to clipboard operation
dspace-angular copied to clipboard

ngVars cause duplicate thumbnail bitstream requests

Open bram-atmire opened this issue 1 year ago • 3 comments

Describe the bug On pages where thumbnails are requested, Angular sends 2 requests to retrieve the bitstream instead of one.

Screenshot 2024-06-18 at 14 16 19

Cause & solution approach

This is likely caused by the use of ngVars here and here

One path to address this would be to replace the occurences with their values.

To Reproduce Steps to reproduce the behavior:

  1. Open up inspect element
  2. Go to https://demo.dspace.org/search?spc.page=1&query=%22A%20Strength-Based%20Approach%20to%20Indigeneity,%20Equity,%20Diversity,%20and%20Inclusion%20Program%20Evaluation%20in%20Higher%20Education%22 this is a search that should return two items with thumbnails
  3. Check how many "content" requests there are

Expected behavior There should be 2 content requests, one per file

Observed behavior There are 2 requests per file

Related work Link to any related tickets or PRs here.

bram-atmire avatar Jun 18 '24 12:06 bram-atmire