dspace-angular
dspace-angular copied to clipboard
[#3111] fix markdown rendering applying before mathjax rendering
References
- Fixes #3111
Description
With this PR, LaTeX formulas are rendered with mathjax before any markdown rendering is applied. This fixes unwanted behaviors described on the linked issue.
Instructions for Reviewers
List of changes in this PR:
- Applied mathjax rendering before markdown rendering (if mathjax is enabled);
- Removed
nativeWindowinjection inclient-math.service(since it's a Client-Side-Rendering service, there is no need to use the injection); - Included the popular LaTeX
$$delimiter in the list of approved delimiters.
To test this PR, try to use this text in any place where the markdown rendering is enabled:
...measurements in (EDT-TTF-CONH$_2$)$_2^{+}$[BABCO$^{-}$] (EDT-BCO) confirmed the absence....
It should render fine, instead of showing a broken formula and some italic text.
Checklist
- [x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
- [x] My PR passes ESLint validation using
yarn lint - [x] My PR doesn't introduce circular dependencies (verified via
yarn check-circ-deps) - [x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
- [x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
- [x] If my PR includes new libraries/dependencies (in
package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation. - [x] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
- [x] If my PR fixes an issue ticket, I've linked them together.