dspace-angular
dspace-angular copied to clipboard
Dspace 7 2357
Hi @tdonohue , I'm @jtimal partner, I like to share this PR with you:
References
- Fixes #2357
Description
Set pagination on groups of the user on profile page
Instructions for Reviewers
On the profile page I added the pagination of groups adding the pagination template and modifying the current service of groups for paginated it. I set 20 elements par page as default in the pagination
List of changes in this PR:
- I created a default variable for group pagination
- I changed the template of group list adding the pagination template
- I added the 'PaginationService' for get the current page in the pagination
- I changed the current services for get groups of the user adding 'Pagination Service' and add the option for paginate the groups, so the pagination component change the current page update the results
Example:
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
- [x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
- [x] My PR passes ESLint validation using
yarn lint - [x] My PR doesn't introduce circular dependencies (verified via
yarn check-circ-deps) - [ ] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
- [x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
- [ ] If my PR includes new libraries/dependencies (in
package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation. - [ ] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
- [x] If my PR fixes an issue ticket, I've linked them together.