dspace-angular
dspace-angular copied to clipboard
Dspace 7 2695
Hi @tdonohue , I'm @jtimal partner, I like to share this PR with you:
References
- Fixes #2695
Description
Add listed results for home search, considering item with thumbnails and without thumbnails
Instructions for Reviewers
I added un number for the results of the search considering the current page and items par page
List of changes in this PR:
- I added the get function named 'isValidForShowItemNumbered' in object-list.component.ts for valid if show the number
- I added the get function named 'getNumber' in 'object-list.component.ts' for return the number considering the previous validation
For watch the change, only go to home and search anything. I attached a example
Example:
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
- [x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
- [x] My PR passes ESLint validation using
yarn lint - [x] My PR doesn't introduce circular dependencies (verified via
yarn check-circ-deps) - [x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
- [x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
- [ ] If my PR includes new libraries/dependencies (in
package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation. - [ ] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
- [x] If my PR fixes an issue ticket, I've linked them together.