dspace-angular icon indicating copy to clipboard operation
dspace-angular copied to clipboard

Delete and Send back buttons on Workflow items perform the same action in Administer workflow section

Open GraziaQuercia opened this issue 1 year ago • 1 comments

Describe the bug In the Administer workflow page, in the case of “Workflow” items, both the “Delete” and the “Send back” buttons perform the same action, sending the selected item back to the workspace of its submitter. We reproduced this behaviour both on DSpace 8 and DSpace 7.6.

To Reproduce

  • log in as admin
  • visit the Administer workflow section in the administration bar
  • search for items in Workflow When clicking on "Send back", the behaviour is correct, and the item gets sent back to the Workspace

https://github.com/DSpace/dspace-angular/assets/124360978/0eece4df-b849-4f7a-b060-e28f2d93b3b8

When clicking on "Delete", the item is, again, sent back to the Workspace

https://github.com/DSpace/dspace-angular/assets/124360978/7859cbd6-9fe5-45f6-9848-6d628f367064

Expected behavior We have the “Delete” button also for “Workspace” items, and in that case, the item is permanently removed from the repository (we also have the modal to confirm the delete action). See video. We suggest to have the same behaviour on the Delete button of an item in Workspace in the Administer Workflow section.

https://github.com/DSpace/dspace-angular/assets/124360978/ee2b1418-2ca4-4f77-8834-5ad0909f1791

Related work Looking at the 7.0 Beta 3 Release Notes, we have a reference on those buttons:

  • Administer Active Workflows allows Administrators to see every submission that is currently in the workflow approval process. From there, they have the option to delete Items (if they are no longer needed), or send them back to the workflow pool (to allow another user to review them). (Login as an Admin, Click "Administer Workflow" in sidebar)

Release Notes - DSpace 7.x Documentation - LYRASIS Wiki

If useful, we fixed the buttons not working on https://github.com/DSpace/dspace-angular/pull/2227

GraziaQuercia avatar May 29 '24 14:05 GraziaQuercia