dspace-angular
dspace-angular copied to clipboard
DSpace
Creative Commons Licence image does not appear on item page.
The Creative Commons licence image and link do not appear in item records in version 7.6. They do appear in version 6.4 (See image below). CC licence information appears in our metadata in 7.6, but not in the item record.
We would like the CC licence image to display on the item page. We would also like the image to link to the licence deed on the Creative Commons website.
Perhaps I'm wrong here, but isn't this more of a UI-issue? If the correct license information is there, we would only have to modify the item-page.component to display the corresponding license, for example by adding a new sub-component like item-licence.component.
@Leano1998 : We generally don't mind which github repository a bug ticket is initially reported in.
That said, we can move this to the "DSpace/dspace-angular" github repository though once someone is able to investigate whether it definitely is a UI-issue. I suspect you may be correct, but I honestly don't know yet whether there need to also be improvements to the Backend (REST API), or if the only necessary changes are on the UI. So, this ticket is simply waiting for someone to investigate further & determine the proper next steps.
I have made a custom component to render the CC license image in the item page, however it is all done in the front-end. Can the issue be moved or should a new one be created in the dspace-angular repo in order to make a PR?
Example:
@autavares-dev : This issue has now been transferred to dspace-angular. Technically, you are welcome to create a PR and link to the issue wherever the issue ticket exists, but I moved it to dspace-angular just to make it easier to locate :) Please feel free to create a PR if you have time/interest.
@tdonohue I have code/PR ready for version 8.x. But I see the issue is related to the DSpace 7.6.x Maintenance project. Can I do the PR for the dspace-angular/main (8.x) branch or is it preferred to use the dspace-7_x branch?
@autavares-dev : You can create a PR for either version. It doesn't matter to us. For small PRs, we have an automatic process which will create a copy of the PR for the other branch (and usually it works well). If the automatic process doesn't work, we will do our best to port it to the other branch.