dspace-angular
dspace-angular copied to clipboard
Submission performance
References
- 7_x REST PR
- 7_x angular PR
- main REST PR
- main angular PR (this PR)
Description
This PR aims to improve performance for submission by removing default full projection for workflow/workspace items and instead allowing support for embedded properties.
Instructions for Reviewers
Changes:
- Added links for "item", "submitter" and "collection" on workflow/workspace items (annotations, link repositories etc.)
- Removed
projection=fullfrom submission item on angular side and replaced with embed parameters, this should reduce a lot of the server and page's load. - Modified test cases that expect embedded properties to either remove the expectation or add embedded parameter to the request
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
- [ ] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
- [ ] My PR passes ESLint validation using
yarn lint - [ ] My PR doesn't introduce circular dependencies (verified via
yarn check-circ-deps) - [ ] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
- [ ] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
- [ ] If my PR includes new libraries/dependencies (in
package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation. - [ ] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
- [ ] If my PR fixes an issue ticket, I've linked them together.