dspace-angular icon indicating copy to clipboard operation
dspace-angular copied to clipboard

Published 20 hours ago • verified publisher icon DSpace

Fix edit relations window

Open Leano1998 opened this issue 9 months ago • 2 comments

References

Add references/links to any related issues or PRs:

  • #2978

Description

This PR currently only enables the automatic closing of the edit-relationships-window on the item-page.

Instructions for Reviewers

List of changes in this PR:

  • Called modalref.close() in the event listener.

Include guidance for how to test or review your PR.

  1. Enable entities
  2. Edit the relationships of an existing entity
  3. Select one or more items to connect
  4. Click Save on the bottom of the modal-window. The window should close after 2 seconds.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • [x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • [ ] My PR passes ESLint validation using yarn lint
  • [ ] My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • [ ] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • [ ] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • [ ] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • [ ] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • [x] If my PR fixes an issue ticket, I've linked them together.

Leano1998 avatar Apr 29 '24 09:04 Leano1998

I also noticed a second problem in in the edit-relations popup: If you want to change the number of items per page or the general order, it doesn't work. I'll try to add a fix for this in here, too. But I didn't found the reason for the bug yet. It might be quite new, because I think it already worked earlier during the DSpace 8 development.

Leano1998 avatar Apr 29 '24 09:04 Leano1998

I will mark, the PR as ready. I wasn't able to solve the second problem yet, but I'll open a second issue, because i noticed the problem on other search-pages as well.

Leano1998 avatar May 02 '24 09:05 Leano1998

PR #3060 refactored the way relationships are added on items and also fixed this bug. So I'm closing this PR since it will conflict with that PR and this PR is also still in draft

alexandrevryghem avatar May 17 '24 20:05 alexandrevryghem