dspace-angular icon indicating copy to clipboard operation
dspace-angular copied to clipboard

Fix Author search result without co-author

Open oscar-escire opened this issue 1 year ago • 1 comments

Hi @tdonohue, I'm @jtimal partner, I like to share this PR with you:

References

  • Fixes #2203

Description

Add a method to search-result-list-element component to show all the authors and if the author's name is highlighted its displayed anyways (if author's list length allow it)

Instructions for Reviewers

To reproduce the error we need an item with two or more dc.contributor.author:

  • Create and deposit a new item
  • Add to metadata two or more dc.contributor.author
  • Use search tool to find the item

List of changes in this PR:

  • Added a method to combine the highlighted authors and other authors' name
  • Changed the method used to displayed the list of authors in result list

Checklist

  • [x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • [x] My PR passes ESLint validation using yarn lint
  • [x] My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • [x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • [x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • [x] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • [x] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • [x] If my PR fixes an issue ticket, I've linked them together.

oscar-escire avatar Apr 25 '24 22:04 oscar-escire

Hi @tdonohue I added a commit removing some trailing spaces and removing some console.logs that I forgot

oscar-escire avatar Apr 26 '24 23:04 oscar-escire

Successfully created backport PR for main:

  • #3041

dspace-bot avatar May 13 '24 19:05 dspace-bot