dspace-angular
dspace-angular copied to clipboard
DSpace
added maxlength and hint to resource policy
Hi @tdonohue, I'm @jtimal partner. We have been working on this issue and we will send you the PR.
References
- Fixes #1719
Description
We have added a maxLength to the name input and a hint to advice max characters.
Instructions for Reviewers
- Add/Edit a policy
- the input only allows to use 30 characters and shows a hint
List of changes in this PR:
- Policy name input max length
- Policy name input hint
- i18n values
Checklist
- [x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
- [x] My PR passes ESLint validation using
yarn lint - [x] My PR doesn't introduce circular dependencies (verified via
yarn check-circ-deps) - [x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
- [x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
- [x] If my PR includes new libraries/dependencies (in
package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation. - [x] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
- [x] If my PR fixes an issue ticket, I've linked them together.
@oscar-escire : Thanks! This PR is currently throwing lint errors (which is why the build is failing). They should be possible to see locally by running yarn lint, and likely you can fix them automatically by running yarn lint --fix
I am sorry I forgot to write, we have also tested:
Checked out PR, tried adding a new policy, 30 character hint appears correctly, and I cannot write a longer than 30 char name. Looks like it works as intended
