dspace-angular icon indicating copy to clipboard operation
dspace-angular copied to clipboard

Fix display of dso names for EPersons

Open floriangantner opened this issue 1 year ago • 0 comments

References

  • Fixes #2947

Description

Extend the EPerson render types to make the dso-name factory for EPersons work.

Instructions for Reviewers

List of changes in this PR:

  • extend Render Type of EPerson with EPerson value. Currently the constructor.name is i falling back to the default factory. Lists of EPerson seems not to be used currently anywhere and the epeople registry uses some table so this should have no impact on other parts of the code.
  • Test Case: people with no last or firstname should now be displayed without leading or trailing whitespace in the epeople registry overview. Before this change these entries should have some whitespace because in the dso-name.service the fallback goes to deprecated dso.name which constructs the name in some other way.
  • provided tests for displaying the eperson name.

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

  • [x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • [x] My PR passes ESLint validation using yarn lint
  • [x] My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • [ ] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • [x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • [ ] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • [ ] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • [x] If my PR fixes an issue ticket, I've linked them together.

floriangantner avatar Apr 17 '24 16:04 floriangantner