dspace-angular
dspace-angular copied to clipboard
feat: add support to Font Awesome Angular library & replace old approach
References
Add references/links to any related issues or PRs. These may include:
- Fixes #2785
Description
In this task I changed an approach to use FontAwesome icons.
Instructions for Reviewers
All fa-icons from font had been changed into the new approach with @fortawesome/angular-fontawesome
The reason why my PR is bigger than 1,000 lines is the idea from task discusion where we decided to replace all old font-awesome approach and remove this implementation at all
List of changes in this PR:
- I removed all
<i class="fa....&<em class="fa...tags - I used an approach with
<fa-layersto improve accessibility for tags - I added 3 sources of icons, follow the @fortawesome/angular-fontawesome documentation
Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Checklist
All icons should be replaced by new approach
- [x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
- [x] My PR passes ESLint validation using
yarn lint - [x] My PR doesn't introduce circular dependencies (verified via
yarn check-circ-deps) - [x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
- [x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
- [x] If my PR includes new libraries/dependencies (in
package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation. - [x] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
- [x] If my PR fixes an issue ticket, I've linked them together.
Hi @pcg-kk, Conflicts have been detected against the base branch. Please resolve these conflicts as soon as you can. Thanks!
Hi @pcg-kk, Conflicts have been detected against the base branch. Please resolve these conflicts as soon as you can. Thanks!
@tdonohue I was talking with my team about solving conflicts on this branch and it look like a lot of work but we have new conflicts every day. Can we create it more sync - I will resolve conflicts, and somebody will check that PR next day to avoid doing the same job few times?
@pcg-kk : As discussed in last week's Dev Mtg, we'll ask @artlowel to give this PR a basic review before conflicts are resolved. Assuming he has no objections to the direction, then we can ask you to solve the conflicts and we'll work to merge it quickly.
(I agree these larger PRs can be difficult to keep conflict-free. So, we'll do our best to move this forward quickly as soon as the general idea is approved.)
While testing another PR I realized I was still using the custom theme. So I tested this PR again using the default theme, and the header issue is gone, so that's only a bug in the custom theme (but should still be fixed)
All the other issues, in regards to icon size and spacing do seem to persist in the default theme though