dspace-angular icon indicating copy to clipboard operation
dspace-angular copied to clipboard

Fix for submission describe warning contribution bug

Open LotteHofstede opened this issue 1 year ago • 2 comments

References

  • Fixes #2904

Description

This PR fixes an issue where on save the first describe step wouldn't show it was validated after saving with certain configurations.

Instructions for Reviewers

Add the follow configuration as the first describe step to the input forms configuration:

   <form name="traditionalpageone">
        <row>
            <field>
                <dc-schema>dc</dc-schema>
                <dc-element>type</dc-element>
                <repeatable>false</repeatable>
                <label>Type</label>
                <input-type value-pairs-name="common_types">dropdown</input-type>
                <hint>Select the type of content of the item.</hint>
                <required>You must enter a type for this item</required>
            </field>
        </row>
    </form>

Start a new submission that uses this configuration and click fill out the first describe step correctly (set a type). Click "Save" and check that the orange (!) icon at the top has changed into a green checkmark.

Checklist

  • [x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • [x] My PR passes ESLint validation using yarn lint
  • [x] My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • [x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • [x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • [x] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • [x] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • [x] If my PR fixes an issue ticket, I've linked them together.

LotteHofstede avatar Apr 08 '24 09:04 LotteHofstede

@tdonohue The codecov check keeps failing, do you have any idea what's wrong?

LotteHofstede avatar Apr 08 '24 11:04 LotteHofstede

@LotteHofstede : I've pushed up a possible fix to Codecov in #2910 . So, if you rebase this PR on the latest main, that may fix the issues. (Codecov has been flakey lately, so I'm hoping that upgrade to the Codecov action will fix the issues)

tdonohue avatar Apr 08 '24 19:04 tdonohue

Successfully created backport PR for dspace-7_x:

  • #2925

dspace-bot avatar Apr 12 '24 17:04 dspace-bot