dspace-angular icon indicating copy to clipboard operation
dspace-angular copied to clipboard

Optimize linting performance by disabling "heavy" warning rules

Open ybnd opened this issue 1 year ago • 0 comments

Describe the bug In my experience, we tend not to pay much attention to ESLint warnings as we do breaking errors. However, it appears that some warning rules are among the most impactful rules in our linting configuration:

  • import/no-deprecated
  • deprecation/deprecated
  • @typescript-eslint/no-floating-promises
  • @typescript-eslint/no-misused-promises

Especially during CI builds it seems counterproductive to do the work of checking these warnings, if we run with --quiet anyway.

We could save about 20s by setting these rules to "off".

To Reproduce Steps to reproduce the behavior:

  1. Run ESLint ~ TIMING=1 yarn run eslint . --quiet
  2. Go over the rules in the "top 10" view, you'll see that many of them are only warnings

Related work #2343

ybnd avatar Mar 14 '24 10:03 ybnd