dspace-angular icon indicating copy to clipboard operation
dspace-angular copied to clipboard

Added Arabic Translation

Open mohamedali654321 opened this issue 1 year ago • 2 comments

Added Arabic Translation

Added ar.json5 translation and modified config files to include this translation

List of changes in this PR:

Added Arabic translation Updated config.example.yml

mohamedali654321 avatar Mar 13 '24 11:03 mohamedali654321

@mohamedali654321 : It looks like this PR is currently failing "lint" (formatting) checks. You can see these locally by running yarn lint. You also may be able to automatically clean them up by running yarn lint --fix (this will fix many things automatically, but may not be able to fix everything)

tdonohue avatar Mar 18 '24 13:03 tdonohue

@mohamedali654321: Could you also restore the comments in the json5 file, these are used to detect outdated translations. So your translation file should look like this:

{
  // "401.help": "You're not authorized to access this page. You can use the button below to get back to the home page.",
  "401.help": "غير مصرح لك بالوصول إلى هذه الصفحة. يمكنك استخدام الزر أدناه للعودة إلى الصفحة الرئيسية.",

  // "401.link.home-page": "Take me to the home page",
  "401.link.home-page": "اذهب إلى الصفحة الرئيسية",
  
  ...
}

alexandrevryghem avatar Mar 18 '24 19:03 alexandrevryghem

Hey @mohamedali654321 because I realise that adding all those comments manually back in would have taken quite a while I created a script to fix your translation file. If you enable this option on your PR I think I can push the fix on your branch: image If this was already enabled I probably just don't have permissions to do this, so could you run the following commands in the terminal of your angular project:

git remote add alexandrevryghem https://github.com/alexandrevryghem/dspace-angular.git
git fetch alexandrevryghem fixed-ar-i18n-file
git push -fu origin alexandrevryghem/fixed-ar-i18n-file:main

This new translation file also already contains all the other missing translations keys in addition.

The only translation key I did not port was the one for cookies.consent.app.description.google-analytics because it had two different values in your file and I wasn't sure which one was the correct one:

  • "cookies.consent.app.description.google-analytics": "يسمح لنا بتتبع البيانات الإحصائية",
  • "cookies.consent.app.description.google-analytics": "تسمح لنا بتتبع بياناتك الإحصائية",
And these translations are also not included because they don't exist in the english file:
  • "collection.page.browse.recent.head": "أحدث التقديمات", -> I removed this key in `en.json5` since it has been replaced with a search page so this is normal
  • "collection.page.browse.recent.empty": "لا توجد مواد للعرض", -> I removed this key in `en.json5` since it has been replaced with a search page so this is normal
  • "menu.section.notifications_reciter": "مطالبة المنشورات",
  • "quality-assurance.button.detail": "عرض التفاصيل",
  • "person.page.givenName": "الاسم الأول",
  • "submission.sections.submit.progressbar.detect-duplicate": "التكرارات المحتملة",
  • alexandrevryghem avatar Apr 14 '24 16:04 alexandrevryghem

    @alexandrevryghem Can you send the script because commenting on a translation line will take a lot of time? Also, the commands sent by you return with an error PS F:\ar-fix\dspace-angular-main> git push -fu origin alexandrevryghem/fixed-ar-i18n-file: main fatal: 'origin' does not appear to be a git repository fatal: Could not read from remote repository.

    Please make sure you have the correct access rights and the repository exists.

    mohamedali654321 avatar Apr 16 '24 13:04 mohamedali654321

    @mohamedali654321 Try running the command git remote add origin https://github.com/knowledgeWare-Tech/dspace-angular.git. I can give you the script but I don't think it will be very useful for you since using it is not simply executing the command there is still some manual work that needs to be done because this was a one off script so I didn't make it super fancy 😅

    alexandrevryghem avatar Apr 16 '24 14:04 alexandrevryghem

    @alexandrevryghem The steps have been followed and the comments have been added, thank you very much

    mohamedali654321 avatar Apr 16 '24 14:04 mohamedali654321

    Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).

    Please cherry-pick the changes locally and resolve any conflicts.

    git fetch origin dspace-7_x
    git worktree add -d .worktree/backport-2863-to-dspace-7_x origin/dspace-7_x
    cd .worktree/backport-2863-to-dspace-7_x
    git switch --create backport-2863-to-dspace-7_x
    git cherry-pick -x 159b0c29de1dcb9a2aff4c9f4ca663d05b573bf3
    

    dspace-bot avatar May 03 '24 20:05 dspace-bot