dspace-angular
dspace-angular copied to clipboard
Avoid metadata representation element is rendered twice when checking the browse configuration
Description
This is a tiny fix to avoid metadata representation element is rendered twice when checking the browse configuration.
This happens for example in the item page for the author metadata list when the request to /server/api/discover/browses/search/byFields?fields=dc.contributor.author,dc.creator is made. The old implementation did not wait for the remote data to be completed, so it could happen that the author's metadata value was rendered as text and immediately afterwards as a link if browse configuration is found.
Instructions for Reviewers
Go to the page https://demo.dspace.org/entities/publication/12623672-25a9-4df2-ab36-699c4c240c7e and verify the behaviour described before. With this PR it should not happen
Checklist
- [x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
- [x] My PR passes ESLint validation using
yarn lint - [x] My PR doesn't introduce circular dependencies (verified via
yarn check-circ-deps) - [x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
- [x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
- [x] If my PR includes new libraries/dependencies (in
package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation. - [x] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
- [x] If my PR fixes an issue ticket, I've linked them together.
Hi @atarix83, Conflicts have been detected against the base branch. Please resolve these conflicts as soon as you can. Thanks!
Hi @atarix83, Conflicts have been detected against the base branch. Please resolve these conflicts as soon as you can. Thanks!
@atarix83 : This has code conflicts. If you wish to have it still considered for 8.0, please get this PR cleaned up and updated to latest main. Otherwise, we'll have to reschedule for 9.0. Thanks!
Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).
Please cherry-pick the changes locally and resolve any conflicts.
git fetch origin dspace-7_x
git worktree add -d .worktree/backport-2853-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-2853-to-dspace-7_x
git switch --create backport-2853-to-dspace-7_x
git cherry-pick -x 91de2e78bc58799b99f2d0a43c2a3f125f278595 07a03bfa2d01b8c87deace41ca5e605ebd87684a
Manually ported to 7.x in #3102