dspace-angular
dspace-angular copied to clipboard
Enhanced community/colletion logo edit
Description When editing an existing Community/Collection the Dspace standard behaviour is redirecting the user back to the Community/Collection page, after it uploads/remove the selected logo. With this PR it's possible to handle the logo remaining in the same edit page. When creating a new Community/Collection the current behaviour for the logo upload is kept.
List of changes in this PR:
- Logo editing is now handled inside the edit itself
- Updated tests to reflect new behaviour
Instructions for reviewers: Please try removing/uploading the logo in community/collection edit Please try creating a new community/collection with and without logo
Checklist
- [x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
- [x] My PR passes ESLint validation using
yarn lint - [x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
- [x] My PR doesn't introduce circular dependencies (verified via
yarn check-circ-deps) - [x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
- [x] If my PR includes new libraries/dependencies (in
package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation. - [x] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
Hi @Sondissimo, Conflicts have been detected against the base branch. Please resolve these conflicts as soon as you can. Thanks!
@Sondissimo : This has code conflicts. If you wish to have it still considered for 8.0, please get this PR cleaned up and updated to latest main. Otherwise, we'll have to reschedule for 9.0
Taking care of it 😀
We have tested this PR. Checked out the PR branch, after uploading a logo, it appears and can be deleted, without being redirected from the edit page. Works as described.
@Sondissimo : If you can find time to fix the bug that I reported in my prior review, we still have time to include this in 8.0. Otherwise, we may need to reschedule it for 9.0
The bug reported was present on Dspace8 already, we provided a fix for it in the last commits 😊