dspace-angular icon indicating copy to clipboard operation
dspace-angular copied to clipboard

French translations for missing parameters (access control and batch loading)

Open pilasou opened this issue 1 year ago • 1 comments

Description

Addition to the json5 french file to fix missing parameters for access control and batch loading in DSpace.

pilasou avatar Feb 22 '24 21:02 pilasou

Thank you @pilasou

I added a few suggestions to the translations. @pilasou : you might want to correct your title issue "French rranslations..."

@tdonohue everything else seems good to me!

mhvezina avatar Feb 23 '24 16:02 mhvezina

@pilasou : This PR appears to be failing lint checks. Could you update it to fix the small issues? They should be visible to you locally by running yarn lint, and you might be able to run yarn lint --fix to fix them automatically. (The automatic fixes don't always work)

tdonohue avatar Apr 19 '24 15:04 tdonohue

@pilasou : There's another lint formatting error now. Here's the new one:

/home/runner/work/dspace-angular/dspace-angular/src/assets/i18n/fr.json5
Lint errors found in the listed files.

  6635:38  error  Parsing error: Unexpected character '“'

It appears to think that one of the double-quotes (") on line 6635 is invalid? Maybe it's accidentally a special character and not a double-quote character? It's unclear to me though because the error isn't obvious when you view this file in GitHub. (My suspicion is maybe this text was copied from a different document like Word and it changed the character)

tdonohue avatar Apr 23 '24 19:04 tdonohue

I've pushed up some additional lint fixes as this still had lint failures. I simply checked out this PR and ran yarn lint --fix to automatically apply the fixes. Once the build succeeds, I'll get this merged & backported to 7.x

tdonohue avatar May 03 '24 16:05 tdonohue

Successfully created backport PR for dspace-7_x:

  • #3006

dspace-bot avatar May 03 '24 16:05 dspace-bot