dspace-angular
dspace-angular copied to clipboard
Small refactoring of Mirador configuration
Description
This is a small refactoring of the Mirador configuration file
Before:
(Mirador.viewer(
{
// settings
},
[
// list of plugins
]
)
)(manifest);
After:
const miradorConfiguration = {
// settings
}
const miradorPlugins = [
// list of plugins
];
Mirador.viewer(miradorConfiguration, miradorPlugins);
This refactoring is useful in situations where the developer wants to make some settings or some plugins depend on a configuration variable
Note that manifest object was already provided as the data property of the settings object
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
- [x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
- [x] My PR passes ESLint validation using
yarn lint - [x] My PR doesn't introduce circular dependencies (verified via
yarn check-circ-deps) - [x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
- [x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
- [x] If my PR includes new libraries/dependencies (in
package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation. - [x] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
- [x] If my PR fixes an issue ticket, I've linked them together.