dspace-angular icon indicating copy to clipboard operation
dspace-angular copied to clipboard

Unauthorised community/collection logo fix

Open Atmire-Kristof opened this issue 1 year ago • 5 comments

References

Fixes #2688

Description

Fixes comcol-page-logo component to create a proper download link for the logo, attaching an authentication token to the url, akin to how thumbnail component handles bitstream urls. This fixes proper view access to the community/collection logo on their pages.

Instructions for Reviewers

How to test:

  • Create a community/collection with a logo
  • Remove resource policies from the logo's bitstream (or restrict it to administrators)
  • Visit the community/collection's page. The logo should be visible when logged in as administrator.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • [x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • [x] My PR passes ESLint validation using yarn lint
  • [x] My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • [x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • [x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • [x] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • [x] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • [x] If my PR fixes an issue ticket, I've linked them together.

Atmire-Kristof avatar Dec 05 '23 14:12 Atmire-Kristof

My changes were trying to authorise the image the moment the component gets loaded, which caused anonymous users to always see the placeholder, even when they have access. I've fixed this to be more in-line with thumbnail component where it'll only try to authorise the image if the request for its content first fails.

Atmire-Kristof avatar Dec 11 '23 15:12 Atmire-Kristof

Hi @Atmire-Kristof, Conflicts have been detected against the base branch. Please resolve these conflicts as soon as you can. Thanks!

github-actions[bot] avatar Jan 25 '24 21:01 github-actions[bot]

@Atmire-Kristof : This has code conflicts. If you wish to have it still considered for 8.0, please get this PR cleaned up and updated to latest main. Otherwise, we'll have to reschedule for 9.0. Thanks!

tdonohue avatar May 03 '24 21:05 tdonohue

I tried to test but I do not know how to make a collection or community logo to be restricted. Could anybody help me how to do that? Thank you!

kanasznagyzoltan avatar May 16 '24 12:05 kanasznagyzoltan

@Atmire-Kristof I would like to test this PR, but I do not know how to make a collection or community logo to be restricted. Could you help me?

kanasznagyzoltan avatar May 28 '24 11:05 kanasznagyzoltan