dspace-angular icon indicating copy to clipboard operation
dspace-angular copied to clipboard

Multiline selected facet badge on search page

Open LotteHofstede opened this issue 1 year ago • 2 comments

References

  • Fixes #2674

Description

This PR fixes an issue where a selected facet badge would overflow the page instead of wrapping around to a new line.

Instructions for Reviewers

Use a long facet filter that would overflow the page and make sure it wraps its text around to a new line. Add multiple facets to make sure everything still works as expected, Eg: http://localhost:4000/search?query=test&spc.page=1&f.subject=Lorem%20ipsum%20dolor%20sit%20amet.%20Et%20iusto%20omnis%20qui%20reprehenderit%20illo%20ut%20provident%20cumque%20ab%20perspiciatis%20delectus.%20Eos%20nemo%20mollitia%20qui%20omnis%20nihil%20ut%20galisum%20obcaecati.,equals&f.author=test,equals&f.author=test123,equals

Checklist

  • [x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • [x] My PR passes ESLint validation using yarn lint
  • [x] My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • [x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • [x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • [x] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • [x] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • [x] If my PR fixes an issue ticket, I've linked them together.

LotteHofstede avatar Nov 30 '23 11:11 LotteHofstede

Hi @LotteHofstede, Conflicts have been detected against the base branch. Please resolve these conflicts as soon as you can. Thanks!

github-actions[bot] avatar Dec 06 '23 16:12 github-actions[bot]

Hi @LotteHofstede, Conflicts have been detected against the base branch. Please resolve these conflicts as soon as you can. Thanks!

github-actions[bot] avatar Mar 20 '24 14:03 github-actions[bot]

Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-7_x
git worktree add -d .worktree/backport-2675-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-2675-to-dspace-7_x
git switch --create backport-2675-to-dspace-7_x
git cherry-pick -x f4dc8ca3d222f774b4424b9dae44577386ca1a28 a026c65a3c6970fae8b72c00667f500a0cff813c

dspace-bot avatar Apr 29 '24 20:04 dspace-bot

Manually ported to 7.x in #2989

tdonohue avatar Apr 29 '24 21:04 tdonohue