dspace-angular icon indicating copy to clipboard operation
dspace-angular copied to clipboard

Turn on no-unused-imports rule and remove all unused imports

Open tdonohue opened this issue 3 years ago • 1 comments

Description

Small PR which bans unused imports in all classes. We already have LGTM warning when unused imports exist. This officially bans unused imports, to ensure our code is kept small (and easy to tree-shake).

Unused imports will now throw an error when yarn lint is run.

tdonohue avatar Oct 24 '22 22:10 tdonohue

This pull request fixes 15 alerts when merging ea4abe8149e46ece5341565a14210e56553c6217 into 1c8d5381000df0a4fddba495a6af26f52802a6ea - view on LGTM.com

fixed alerts:

  • 15 for Unused variable, import, function or class

lgtm-com[bot] avatar Oct 24 '22 22:10 lgtm-com[bot]

This pull request fixes 15 alerts when merging 8427dd6e3c2605c7ffe89b53e84f2dd485e82fb1 into 0395480ab8ddeabe22ff1b7d2c6f678fd9830428 - view on LGTM.com

fixed alerts:

  • 15 for Unused variable, import, function or class

lgtm-com[bot] avatar Oct 27 '22 19:10 lgtm-com[bot]

This pull request fixes 15 alerts when merging a9b28120a9fad6a61fbe384a9a7b426d447a2d66 into f782ee921c0363857521e93bd89624509c3775f4 - view on LGTM.com

fixed alerts:

  • 15 for Unused variable, import, function or class

lgtm-com[bot] avatar Oct 28 '22 14:10 lgtm-com[bot]

This pull request fixes 15 alerts when merging 76c5bdb43012fe72289de03e5b31f663bb126ff8 into e7e049c531affd4c5d167512d30ebc8b98890de8 - view on LGTM.com

fixed alerts:

  • 15 for Unused variable, import, function or class

lgtm-com[bot] avatar Oct 28 '22 14:10 lgtm-com[bot]

Hi @tdonohue, Conflicts have been detected against the base branch. Please resolve these conflicts as soon as you can. Thanks!


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions[bot] avatar Oct 31 '22 15:10 github-actions[bot]

This pull request fixes 15 alerts when merging 4f22aa2f837ac2513ee0c45f72ef6c7cb750eb17 into dc4b4ffe4d16daf43b6c7706058b104ed8c25beb - view on LGTM.com

fixed alerts:

  • 15 for Unused variable, import, function or class

lgtm-com[bot] avatar Oct 31 '22 20:10 lgtm-com[bot]

This pull request fixes 15 alerts when merging cc86ba539fc0d66ddcaf0777c2a0fb1e3476b15f into 340cc0aa3f422dc79511ef83dbae058340c5db15 - view on LGTM.com

fixed alerts:

  • 15 for Unused variable, import, function or class

lgtm-com[bot] avatar Nov 08 '22 15:11 lgtm-com[bot]