dspace-angular
dspace-angular copied to clipboard
Minor fixes related to line breaks & Markdown in metadata fields
References
- https://github.com/DSpace/dspace-angular/pull/1851
Description
This PR bundles a few minor fixes related to https://github.com/DSpace/dspace-angular/pull/1851
-
Even spacing between comma-separated MDVs (e.g. subjects)
This was an older issue, caused by line breaks within the
<span>
, which Angular translates into unwanted spacing. Now we include a space in the separator itself:', '
-
Made
enableMarkdown
an input ofds-generic-item-page-field
so it's easier to enable Markdown for arbitrary Item page fields -
When the new
dsMarkdown
pipe is combined with the new.preserve-line-breaks
CSS class, line breaks in Markdown are effectively doubled. Therefore, we shouldn't add this class when rendering Markdown.
Instructions for Reviewers
Confirm that this PR solves the issues listed above and that the changes are sensible.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
- [x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
- [x] My PR passes TSLint validation using
yarn run lint
- [x] My PR doesn't introduce circular dependencies
- [x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
- [x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
- [x] If my PR includes new, third-party dependencies (in
package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
The e2e failures seem entirely unrelated to the changes here, so I'm hoping they're random.