dspace-angular icon indicating copy to clipboard operation
dspace-angular copied to clipboard

Published 20 hours ago • verified publisher icon DSpace

Submission enters an endless loop, when depositing with errors and no unsaved changes

Open hutattedonmyarm opened this issue 3 years ago • 2 comments

Describe the bug

When depositing a submission a second time (e.g. after the first one failed validation) without any changes. the submission form enters an endless loop, requesting, re-requesting, and re-requesting the workspace item.

Version: DSpace 7.4

To Reproduce Steps to reproduce the behavior:

  1. Start a submission
  2. Do not fill out all required forms
  3. Click the Deposit button
  4. Wait for the validation errors to appear
  5. Click the Deposit button again, without making any changes

Expected behavior The submission should fail validation again

hutattedonmyarm avatar Oct 21 '22 13:10 hutattedonmyarm

@hutattedonmyarm : I'm not able to reproduce this bug either on our demo site (https://demo7.dspace.org) or on my local copy of 7.4. Here's what I'm doing:

  1. Login and go to MyDSpace
  2. Start a new Item submission
  3. Immediately click "Deposit" without filling out any fields. I see the "Deposit cannot be completed..." popup & required fields are highlighted in red.
  4. Wait for popup to disappear. Click "Deposit" again. Same result, popup displays again.
  5. Wait for popup to disappear. Click "Deposit" again. Same result.
  6. Now fill out required fields. Click Deposit. Everything works, deposit completes successfully.

So, either you are doing something different, or this may have to do with a custom code change on your end (or maybe some custom field you added to the submission form)?

Please let us know if you can determine a way to reliably reproduce this with DSpace 7.4. Until then, I'm going to flag this as "cannot reproduce", but I'll leave the ticket open temporarily for you to re-verify.

You may also want to look at our Troubleshooting guide, which might help you track down the cause of the error on your end: https://wiki.lyrasis.org/display/DSPACE/Troubleshoot+an+error#Troubleshootanerror-DSpace7.x(orabove)

tdonohue avatar Oct 21 '22 14:10 tdonohue

@tdonohue I've managed to reproduce it with vanilla dspace-angular, so it looks to be related to either our submission process (we have a fairly large submission form, using type-binds, scopes, and entity relations) or our backend process. I'll need to look further into it!

Update: I was able to reproduce it on your demo site! I found a collection which is using the Publication entity, by going to My DSpace, click the plus button to start a new submission and then choosing Publication from the dropdown menu. Currently, only a single collection seems to be working with entities: Publicações > Articles. From there, follow your own steps again

hutattedonmyarm avatar Oct 24 '22 09:10 hutattedonmyarm

@hutattedonmyarm : I was able to reproduce it now on both the demo site, and locally. It seems to only be reproducible if you use Entities, specifically the Publication Entity submission form. It doesn't occur if you submit a normal Item (non-Entity)

I'll pull this ticket over to our 7.5 board and see if I can find a volunteer to look at it.

tdonohue avatar Nov 01 '22 14:11 tdonohue

Needs retesting in 7.6, as several improvements / bug fixes to submission form occurred in that release.

tdonohue avatar Jun 29 '23 20:06 tdonohue

@tdonohue I just checked on the demo site, I'm still able to reproduce it there

hutattedonmyarm avatar Jun 30 '23 07:06 hutattedonmyarm