dspace-angular
dspace-angular copied to clipboard
Add delete process functionality
References
- Fixes #1660
Description
This PR contains functionality to delete processes.
On a process page, a delete button has been added that will delete the current process and navigate the user back to the overview page.
On the overview page, a trash bin icon has been added that can be clicked to toggle a process for deletion. This allows a user to select a bunch of processes for deletion. When 1 or more processes are selected, a button will be shown to delete all the processes.
Instructions for Reviewers
To test the individual process deletion, perform the following steps:
- Navigate to a process detail page
- Click the delete button
- Confirm the delete in the popup
- Verify that you are navigated to the overview page and that the process has been deleted
To test the bulk process deletion, perform the following steps:
- Navigate to the process overview page
- Click the trash icon for different processes on different pages
- Verify that the delete button contains a count of all selected processes
- Click the delete button
- Confirm the delete in the popup
- When the deletion is in progress the popup will remain to prevent the user from deleting the same processes or navigating to processes that are being deleted
- Upon completion, verify that the popup closes and a notification is shown containing the number of successful deletes
- When a deletion fails, a separate error notification is shown for the failed process
Checklist
- [x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
- [x] My PR passes TSLint validation using
yarn run lint - [x] My PR doesn't introduce circular dependencies
- [x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
- [x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
- [x] If my PR includes new, third-party dependencies (in
package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
This pull request introduces 1 alert when merging d5605e43d433ba477f9c6ce69bdc85975e120974 into 9a5a7c13068af5db56b9450e1d4f004ac59f606c - view on LGTM.com
new alerts:
- 1 for Unused variable, import, function or class
This pull request introduces 1 alert when merging 72852dd031060887a7112d769f51be449157ce24 into 9a5a7c13068af5db56b9450e1d4f004ac59f606c - view on LGTM.com
new alerts:
- 1 for Unused variable, import, function or class
Merging as this is at +2 approvals