dspace-angular icon indicating copy to clipboard operation
dspace-angular copied to clipboard

Make create, edit community/collection/item dialogs theme-able.

Open mwoodiupui opened this issue 3 years ago • 1 comments

Description

See the title. This is an elaboration of local work that was needed to create a custom new-item dialog in our local theme (instead of hacking the stock dialog).

Instructions for Reviewers

List of changes in this PR:

  • Create themed wrappers for the dialog components.
  • Use them in the menu resolver, in place of the un-themed components.

Checklist

  • [x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • [x] My PR passes TSLint validation using yarn run lint
  • [x] My PR doesn't introduce circular dependencies
  • [x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • [x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • [x] If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

mwoodiupui avatar Aug 19 '22 20:08 mwoodiupui

This is draft because I'm running Node v18 but the specified Webpack and eslint-plugin-jsdoc require an earlier version.

mwoodiupui avatar Aug 19 '22 20:08 mwoodiupui

I have a knack for starting out to learn with a problem that seems simple but turns out to be difficult or unusual. Thanks for a thorough critique.

mwoodiupui avatar Sep 06 '22 19:09 mwoodiupui