dspace-angular icon indicating copy to clipboard operation
dspace-angular copied to clipboard

Edit Item > Authorizations > Policy Group change does not appear

Open alawvt opened this issue 3 years ago • 3 comments

Describe the bug In DSpace 7, Edit Item > Authorizations..., e.g. https://demo7.dspace.org/items/03731881-2185-4baf-a6a8-1438a4d29dc8/edit/authorizations, after one changes a Policy Group, no Group appears for that Policy.

To Reproduce

  1. Before any changes, Policies for Bundle ORIGINAL is Group="Anonymous." DSpace7_edit_policies_1
  2. I have changed Policies for Bundle ORIGINAL to Group="rebit ecm." This change does not appear (no Group appears). DSpace7_edit_policies_2
  3. I refreshed the page. The new Group="rebit ecm" now appears. Dspace7_edit_policies_3

Expected behavior After a policy is changed and saved the new group should immediately appear.

Related work Link to any related tickets or PRs here.

alawvt avatar Aug 08 '22 19:08 alawvt

This is a subset of problem described in #644 (which is the larger issue), see this comment: https://github.com/DSpace/dspace-angular/issues/644#issuecomment-1137766491

Nonetheless, I'm going to leave this open until #644 is resolved. I suspect they are essentially the same issue.

tdonohue avatar Aug 23 '22 20:08 tdonohue

It looks like this is an issue with the invalidation of the alternative links on the policy object after it has been updated. We should also take the opportunity to refactor the ResourcePoliciesComponent itself to get rid of the method calls for the eperson and the group in its template as those are horrible for performance (they'll be re-evaluated multiple times per second)

Solving this, and https://github.com/DSpace/dspace-angular/issues/644 will take an estimated 12 hours

Atmire would like to claim these tickets

artlowel avatar Sep 01 '22 12:09 artlowel

@artlowel : That sounds reasonable & I'll assign this ticket & #644 back to you for your team to work on.

tdonohue avatar Sep 01 '22 13:09 tdonohue

I have tested this with DSpace 7.4 on DSpace 7 Demo and the new group immediately appears after a change. Thank you for fixing this.

alawvt avatar Oct 11 '22 20:10 alawvt