remove hard coded "or" label - use i18n translation key lookup instead

[saschaszott]

Describe the bug

Two template files contain a hard coded "or" which should be replaced by an translation key lookup:

<span class="px-4 bg-white">or</span>

• src/app/shared/search-form/scope-selector-modal/scope-selector-modal.component.html
• src/app/shared/dso-selector/modal-wrappers/create-community-parent-selector/create-community-parent-selector.component.html

What is the common translation key naming scheme used in DS-UI? Could you please suggest an appropriate key name.

[tdonohue]

@saschaszott : I recommend looking at those files for other i18n keys and creating a key alongside it for that text.

I see the scope-selector-modal.component.html file uses keys that start with dso-selector.* here: https://github.com/DSpace/dspace-angular/blob/main/src/assets/i18n/en.json5#L1320-L1364 You could add a new key to that section for the "or" text.

It looks like the create-community-parent-selector.component.html uses those same i18n keys... as I see it uses dso-selector.create.community.top-level in that file (and a few others). So, it could reuse that same text.

[corrad82-4s]

We at 4science can fix this all at once with https://github.com/DSpace/dspace-angular/issues/1728 and https://github.com/DSpace/dspace-angular/issues/1726 . Roughly it won't take longer than 1 or 2 hours

[tdonohue]

@corrad82-4s : Thanks, I'll assign all 3 of these tickets to you for 7.5. I'll just add a 2 hour estimate to this ticket, and make the other two tickets zero hour estimates.