dspace-angular icon indicating copy to clipboard operation
dspace-angular copied to clipboard

Missing translations in publication search modal dialog (publications of author)

Open saschaszott opened this issue 3 years ago • 3 comments

Describe the bug

missing translations of submission.sections.describe.relationship-lookup.title.isPublicationOfAuthor and submission.sections.describe.relationship-lookup.search-tab.tab-title.isPublicationOfAuthor

image

To Reproduce

Steps to reproduce the behavior:

  1. enable "configurable entites" feature
  2. establish a "person" collection
  3. assign default "Person" submission form to collection created in step 2
  4. open submission form of collection created in step 2
  5. click on publication lookup button (button with fa-search icon)

Expected behavior

both keys are translated

saschaszott avatar Jul 15 '22 15:07 saschaszott

Hi @saschaszott : If you find missing translation keys of this sort, we'd welcome a PR (especially if you know or can figure out what it should say). The various translations of the DSpace UI are all provided by volunteers...so they do occasionally get outdated & require updates. It seems this one likely is only missing those keys because those keys were added after the initial translation was contributed to DSpace. So, if you have any updates to the translation to suggest, we'd welcome a PR! Otherwise, we'll have to wait to find a volunteer who can help us translate these keys.

tdonohue avatar Jul 15 '22 15:07 tdonohue

Hi @tdonohue , the two translation keys mentioned above are still missing in the "default" i18n file (en.json5).

saschaszott avatar Jul 18 '22 08:07 saschaszott

@saschaszott : Yes, what I meant to add is that we also welcome PRs if you discover a missing translation key in en.json5. It appears (at a glance) this key is a dynamic one (based on the type of relationship)...and somehow it was never added to en.json5.

I'll move this over to the 7.4 board in search of a volunteer... but if you want to help add the key to en.json5 (even even a German translation), we'd welcome a PR. Just let us know.

tdonohue avatar Jul 20 '22 15:07 tdonohue

Added zero hour estimate as this will be included in the fix for #1729.

tdonohue avatar Nov 28 '22 15:11 tdonohue