dspace-angular icon indicating copy to clipboard operation
dspace-angular copied to clipboard

In facets, vertically align checkbox with first word of option

Open alawvt opened this issue 3 years ago • 6 comments

Describe the bug DSpace 7.2? As first reported in https://groups.google.com/g/dspace-community/c/GMO020isfZQ/m/1ISexkihAwAJ, in facets, the check box for each option seems to be vertically centered on each option. This is fine for single lines but is confusing for multi-line options. For example, the ETD collection in the Iowa State University repository running DSpace 7.2, https://dr.lib.iastate.edu/collections/0830d32e-14e1-4a4f-bb8f-271a75ed35af?scope=0830d32e-14e1-4a4f-bb8f-271a75ed35af, offers a Department facet with the long option, Civil, Construction, and Environmental Engineering. I propose putting the check box inline with the first word of each option. I observe this in Firefox but not in Chrome or Safari. Attached are screenshots of each. [Note also that checkboxes in Safari overlap the text for some options.]


Firefox
Firefox_facet_checkbox


Chrome
Chrome_facet_checkbot


Safari
Safari_facet_checkbox


A clear and concise description of what the bug is. Include the version(s) of DSpace where you've seen this problem & what web browser you were using. Link to examples if they are public.

To Reproduce Steps to reproduce the behavior:

  1. Do this
  2. Then this...

Expected behavior A clear and concise description of what you expected to happen.

Related work Link to any related tickets or PRs here.

alawvt avatar Jun 28 '22 17:06 alawvt

I'm seeing slightly different misalignment on Firefox 103.0.2 20220825-103353

ybnd avatar Aug 25 '22 08:08 ybnd

Thanks, @ybnd, thank you for sharing your view. Is that a site that I could test? In Firefox 104.0, the page that I linked above still looks the same as the first screenshot.

alawvt avatar Aug 25 '22 12:08 alawvt

@alawvt that was on the demo site: https://demo7.dspace.org/search Now that you mention it, it does appear centered https://dr.lib.iastate.edu for me as well -- so it's probably due to the theme there?

ybnd avatar Aug 25 '22 12:08 ybnd

Thanks, @ybnd, the subjects on the Demo site look fine for me, too. So maybe it is a theme issue at https://dr.lib.iastate.edu/. Therefore, I'd be fine with closing this issue, @tdonohue.

alawvt avatar Aug 25 '22 12:08 alawvt

I'd suggest leaving it open since the default style in FF is still off compared to other browsers (just not vertically) & we could look at the spacing issue on Safari as well

ybnd avatar Aug 25 '22 12:08 ybnd

Ok. Here's Safari DSpace7_facets_Safari and Chrome. DSpace7_facets_Chrome

alawvt avatar Aug 25 '22 13:08 alawvt

Closing, as alignment issues no longer exist in Firefox or Chrome or MS Edge. I suspect this was fixed in #2018 or some similar change in 7.5

tdonohue avatar Feb 27 '23 20:02 tdonohue