Pet Colors

[PThagaard]

Black Wolf, changes to white wolf.

Red to blue and so on.

The color changes - but the selected color and the showed color - are 2 very different things.

[PThagaard]

Wolf's:

Black = White Blue=Yellow Brown=Light Blue Cyan=Pink Gray=Light Gray Green=Magenta Lime=Purple Orange=Red

[DSH105]

Not sure I understand what you mean here.

[South-Paw]

I've just spent a bit of time trying to figure out where the problem is (in hope of fixing it for you) but I can't find what to blame for it....

What this issue relates to though is the Wolfs collar color menu; the colored wool you click on doesn't give the correct colored collar.

Eg: clicking on black wool for a collar gives a white collar and clicking on the white wool for a white collar gives a black collar.

[South-Paw]

@DSH105 My comment above hopefully identifies the issue a bit better

[DSH105]

Yeah, thank you :). I haven't really looked into it that much yet though.

[JamieSinn]

More information @DSH105 http://www.ecocitycraft.com/forum/threads/pet-wolf-collar-colour-bug.129504/

[DSH105]

I believe @Harry5573 may have resolved this in #539 (https://github.com/DSH105/EchoPet/pull/539/files#diff-89ba8f1e527bd5e10ad0d0d4563647adR88). I haven't drafted a new minor release yet, but there are development builds available if anyone is willing to test it.

[harrydevane]

@DSH105 I fixed it v1_7_R1-v1_7_R4 for 1.7 clients, and also added a converter in the protocol-hack listener to fix it for 1.8 clients on v1_7_R4 (https://github.com/Harry5573/EchoPet/blob/ca601dbee5d32e206500ad17acd8862bb6914d43/modules/EchoPet/src/main/java/com/dsh105/echopet/compatibility/SpigotProtocolHackPacketListener.java#L143), i didn't touch real-1.8 spigot modules though, so could still be broken there.

[DSH105]

Above commit should bring the 1.8.x modules back into line with NMS.

[klugemonkey]

Collars still not working 1.8.3+ modules\EchoPet\pom.xml is missing dependency for EchoPet-v1_8_R3 and Dye enums (I believe used for collars) are reverse of Wool enums -> (byte) 15 - dc.getWoolData()

[klugemonkey]

This fixes the issue on 1.8.3+:

@Override
public void setCollarColor(DyeColor dc) {
    if (((IWolfPet) pet).isTamed()) {
        int colour = 15 - (int)dc.getWoolData();
        this.datawatcher.watch(20, Byte.valueOf((byte)colour));
    }
}