chore: change options pydantic schema to base options

Open simjak opened this issue 1 year ago • 2 comments

Rapid OCR options were missing in Pydantic validation, so changed to use base options OcrOptions

Checklist:

[ ] Documentation has been updated, if necessary.
[ ] Examples have been added, if necessary.
[ ] Tests have been added, if necessary.

Dec 03 '24 07:12 simjak

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

[X] title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

Dec 03 '24 07:12 mergify[bot]

@simjak I agree we need a fix for RapidOcr, but I would like to have RapidOcrOptions in the Union instead. I think it is necessary for discovery of legal CLI arguments. See: https://github.com/DS4SD/docling/issues/505

Dec 03 '24 15:12 cau-git

@simjak we will close this in favour of https://github.com/DS4SD/docling/pull/544 which includes a fix.

Dec 09 '24 08:12 cau-git