deepsearch-toolkit icon indicating copy to clipboard operation
deepsearch-toolkit copied to clipboard

feat: relax `typer` requirement constraints

Open davidberenstein1957 opened this issue 2 years ago • 4 comments
trafficstars

The enforced typer constraints typer<0.5.0 and >=0.4.0 seem a bit restrictive and don't allow installing it i.c.m. argilla.

davidberenstein1957 avatar Oct 20 '23 10:10 davidberenstein1957

Thanks @davidberenstein1957 we will have a look. I don't remember the exact reason, but if it is minor we will for sure relax it. We only have to be careful with pydantic updates, because they involve a few components.

dolfim-ibm avatar Oct 20 '23 14:10 dolfim-ibm

I was just looking it up, we have already typer=^0.9.0, https://github.com/DS4SD/deepsearch-toolkit/blob/main/pyproject.toml#L43

dolfim-ibm avatar Oct 20 '23 14:10 dolfim-ibm

@davidberenstein1957 is this still an issue?

dolfim-ibm avatar Feb 20 '24 18:02 dolfim-ibm

It is not at the moment but if there are no major differences setting typer to something like typer>=0.7.0,typer<1 might give some bandwidth when installing with other packages.

davidberenstein1957 avatar Feb 21 '24 08:02 davidberenstein1957