nds-bootstrap icon indicating copy to clipboard operation
nds-bootstrap copied to clipboard

[CODE SUGGESTION] Dynamically compile .lz77 instead of having static files for /retail/nitrofiles

Open NightScript370 opened this issue 2 years ago • 2 comments

The issue template is non-applicable for this, so it has been removed.

Currently, we place static .lz77 files within the nitrofiles, which means that they need to be preprosessed on the repo to be published. The disadvantage this has is for those that want to know exactly what's in the lz77 file, it'd be much more difficult than if we were to show them the process. Therefore, I'd suggest a new build system:

  1. Rename the current nitrofiles to a new folder titled nitrofiles_source
  2. Copy any file not containing the prefix of "lz77." directly to /nitrofiles/
  3. For files containing the prefix of "lz77.", compress them then copy the compressed version to nitrofiles

BENEFITS:

  • No duplicated compressed and non-compressed files in the DS's nitrofiles
  • Still gives easy source view for INI.

AFFECTED FILES:

  • https://github.com/DS-Homebrew/nds-bootstrap/blob/master/retail/nitrofiles/bootloader_images.lz77
  • Files from https://github.com/DS-Homebrew/nds-bootstrap/tree/master/retail/nitrofiles/fonts

NightScript370 avatar Aug 15 '22 19:08 NightScript370

Still gives easy source view for INI.

What INI file is being LZ77 compressed? I don't see anything that's an ini, the bootloader_images.bin is just raw 16-bit image data I think so if anything we could maybe just remove the decompressed file from the repo.

The fonts too are kinda useless as decompressed bins, if you want to edit the fonts you'll edit the XCF files so there's not really any reason I see to store those uncompressed in the repo.

Epicpkmn11 avatar Aug 15 '22 19:08 Epicpkmn11

Oh, I was moreso saying that for the simple ini folders that wouldn't be compressed, they could still easily be viewed since they will simply be copied as opposed to having to deal with compressing the entire thing. My english is just bad this morning.

NightScript370 avatar Aug 15 '22 19:08 NightScript370