deep_learning_cookbook icon indicating copy to clipboard operation
deep_learning_cookbook copied to clipboard

Merge updates for Japanese translation.

Open ohtaman opened this issue 5 years ago • 7 comments

ohtaman avatar Apr 29 '19 01:04 ohtaman

Sorry, this PR is sent by mistake

ohtaman avatar Apr 29 '19 02:04 ohtaman

Sorry about that, inadvertently closed this.

DOsinga avatar Apr 30 '19 16:04 DOsinga

Sorry, this PR my mistake and so I closed this by myself.

In fact, now I'm trying to update whole samples for the Japanese version of your book. Is there any good way to collaborate with this original repository? Now, we are working to

  • support TensorFlow 2.0.
  • remove/update some redundant codes.
  • maybe remove some code which uses outdated libraries or methods.
    • and it may be possible to add new more modern codes.
  • translate markdowns to Japanese.

I believe some of the above (maybe except the last one) are worthful also for this original repository.

ohtaman avatar May 01 '19 21:05 ohtaman

Yes, that sounds great!

Why don't you send me a PR with the English only changes and then we just create a separate repository for the Japanese version? I don't think notebooks support dual language yet :)

I'm at [email protected] if you want to email directly. Happy to chat on whatever medium.

DOsinga avatar May 01 '19 22:05 DOsinga

Hey!

How is this going? I pushed some updates and fixes partly based on your work. Happy to incorporate anything else that is reasonable. Let me know!

Douwe

DOsinga avatar May 19 '19 15:05 DOsinga

Hi! Now we are working on translation towards publishing, hopefully in September.

Since it is diffucult to manage *.ipynb on git (difficult to see diff, difficult to resolve conflicts, ... ), I want to keep PRs simple. Thus I'm thinking to close this PR and create other branches and PRs per .ipynb file. Is it OK?

ohtaman avatar May 20 '19 01:05 ohtaman

FYI: https://app.reviewnb.com/ maybe help to treat ipynb on github. I use this tool for tensorflow/docs translation.

ohtaman avatar May 20 '19 01:05 ohtaman