domjudge icon indicating copy to clipboard operation
domjudge copied to clipboard

Initial code for a mobile friendly scoreboard.

Open nickygerritsen opened this issue 10 months ago • 7 comments

Missing:

  • ❤️.
  • Probably some logic based on whether things are enabled (like problems). Affiliation display logic should be mostly there.
  • Extensive testing for non-finals settings.
  • Maybe some cleanup of the code/logic.
  • Maybe not do this on non public scoreboards?

But we want to use this for the public scoreboard in Luxor, so hence this initial PR.

nickygerritsen avatar Apr 06 '24 10:04 nickygerritsen

Maybe not do this on non public scoreboards?

Agreed.

What is strange: I looked now on my phone (and not with chrome devtools) and it is way too wide... but only until the first refresh, then it's fine. Do we fix the width too late?

meisterT avatar Apr 08 '24 18:04 meisterT

Might be that I broke something when moving this to the js file. Will check

nickygerritsen avatar Apr 08 '24 18:04 nickygerritsen

I quickly looked into the hearts. It is non-trivial to re-use the same code, so we might have to duplicate it.

meisterT avatar Apr 08 '24 18:04 meisterT

Might be that I broke something when moving this to the js file. Will check

Should be fixed now, it indeed executed the javascript before the page was loaded, which broke when I moved the code to the .js file.

It now also only shows the mobile scoreboard on the public page.

nickygerritsen avatar Apr 08 '24 18:04 nickygerritsen

@nickygerritsen you want to retarget this to wfastana?

vmcj avatar Sep 06 '24 17:09 vmcj

I rebased it on Astana then rebased Astana on this so it's already there. Changing the target will tell you hopefully there are no changes

nickygerritsen avatar Sep 06 '24 18:09 nickygerritsen