dataRetrieval icon indicating copy to clipboard operation
dataRetrieval copied to clipboard

readWQPsummary updates

Open ldecicco-USGS opened this issue 2 years ago • 3 comments

  1. The WQP summary service doesn't seem to accept the start/end dates. We should either give user a warning that the dates aren't included in the query OR do the data filtering on our own. Another suggestion might be to as if WQP wants to implement it.
  2. If users somehow notice from the WQP site itself that all summary queries have the dataProfile="periodofrecord", then I think we need to check that we're not double specifying it in the URL.

ldecicco-USGS avatar Mar 24 '22 19:03 ldecicco-USGS

In response to the items noted here:

  1. start/end dates are currently not allowed parameters for the WQP summary service. This could be implemented in a future version of the summary service.
  2. 'periodofrecord' is the most common dataProfile queried by the summary service, however there is also 'summaryMonitoringLocation', which is actually the default dataProfile. If no dataProfile is specified, the service will return data in the 'summaryMonitoringLocation' format.
  • Some of the confusion with the summary service should be alleviated when the revised documentation is published on the WQP site, which should be soon!

lstanish-usgs avatar Mar 24 '22 21:03 lstanish-usgs

But summaryMonitoringLocation is only with geojson so we'll need to adjust the code for that unique format relative to dataRetrieval.

ldecicco-USGS avatar Mar 25 '22 00:03 ldecicco-USGS

And also if any current dataRetrieval user is reading this.... at the moment, in dataRetrieval, if no dataProfile is specified in the readWQPsummary function, then dataRetrieval adds dataProfile="periodofrecord". When we were developing this function, there wasn't actually any dataProfile=summaryMonitoringLocation output to test. The summaryMonitoringLocation profile will need some work to get it incorporated in dataRetrieval.

ldecicco-USGS avatar Mar 25 '22 00:03 ldecicco-USGS

dealing with the "summaryMonitoringLocation" will be revisited in the WQX 3 profile work. Closing this for now since it's a mis-mash of issues.

ldecicco-USGS avatar Oct 04 '23 16:10 ldecicco-USGS