EGRET
EGRET copied to clipboard
Issue with flow normalized concentration and flux values when using only one year of data
Running WRTDS with only one year of data, I expect the predicted flow normalized concentration and flux (columns FNConc and FNFlux) and non-flow normalized predicted concentration and flux (column ConcDay and FluxDay) from from the getDaily()
function to be the same, since the normalization is only able to use one year. However, when I run with only one year of data, the FN and non-FN values start to diverge after 2/28 (59th day of the year).
Reviewing the code, I suspect there may be an issue with the bin_Qs() function and how it handles the leap day, or possibly in line 106 of estDailyFromSurfacesJ.R:
When I replace allLogQsReplicated <- allLogQsByDayOfYear[localDaily$Day]
with allLogQsReplicated <- allLogQsByDayOfYear[localDaily$i]
the FN and non-FN values match the entire year. I'm not sure if bin_Qs() should be updated or the above referenced line.