ACE_TAO icon indicating copy to clipboard operation
ACE_TAO copied to clipboard

Published 20 hours ago • verified publisher icon DOCGroup

[ace6tao2] Comparison warning in CDR_Base.cpp

Open jwillemsen opened this issue 2 months ago • 4 comments

Warning in ACE using bcc32 on ace6tao2 branch, introduced by https://github.com/DOCGroup/ACE_TAO/pull/2196

.\CDR_Base.cpp:
Warning W8012 .\CDR_Base.cpp 938: Comparing signed and unsigned values in function ACE_CDR::Fixed::from_string(const char *)

jwillemsen avatar Apr 15 '24 10:04 jwillemsen

Both sides of the comparison are unsigned. Is there a CI build that shows the warning - or could one be added?

mitza-oci avatar Apr 15 '24 22:04 mitza-oci

Working on new CI builds, need to create first a base line. Are they different sizes, if so, one could be promoted to signed before the comparison

jwillemsen avatar Apr 16 '24 06:04 jwillemsen

See https://download.remedy.nl/buildlogs/win_cbxe15_bcc32_acetao_debug/

jwillemsen avatar Apr 17 '24 08:04 jwillemsen

It's size_t and an unsigned char. Why would a compiler change the signedness (apparently that's a real word) of a value and then complain about it?

iguessthislldo avatar Apr 17 '24 15:04 iguessthislldo