ACE_TAO icon indicating copy to clipboard operation
ACE_TAO copied to clipboard

Simplify Includes

Open iguessthislldo opened this issue 3 years ago • 5 comments

Used a script to find places where a preprocessor include starts with the directory of the including file and removed that part of the path to turn it into a relative path.

iguessthislldo avatar Dec 13 '20 08:12 iguessthislldo

Ok, this looks to work but personally I find it less obvious which file is included, I would prefer to keep the paths there

jwillemsen avatar Dec 13 '20 10:12 jwillemsen

I find it less obvious which file is included

It is missing the other part I'm trying to do in OpenDDS which is just using #include <> for non-relative includes. That way its more obvious. This is what's recommend by the C++ Core Guidelines,

iguessthislldo avatar Dec 13 '20 22:12 iguessthislldo

It is missing the other part I'm trying to do in OpenDDS which is just using #include <> for non-relative includes. That way its more obvious. This is what's recommend by the C++ Core Guidelines,

Ok, but when we want to use #include <some_library/common.h> for ACE/TAO within the unit tests it looks much easier to keep the ace and tao prefix, that makes a global replace much easier than when you remove ace and tao right now

jwillemsen avatar Dec 23 '20 17:12 jwillemsen

If I understand you correctly, do you mean for example using ace/Reactor.h instead something like of ../../ace/Reactor.h in a test? If so I agree with you and these changes don't do anything like that. There are no changes outside of ACE/ace, ACE/ACEXML, TAO/tao, and TAO/orbsvcs.

iguessthislldo avatar Dec 24 '20 07:12 iguessthislldo

If I understand you correctly, do you mean for example using ace/Reactor.h instead something like of ../../ace/Reactor.h in a test? If so I agree with you and these changes don't do anything like that. There are no changes outside of ACE/ace, ACE/ACEXML, TAO/tao, and TAO/orbsvcs.

I was thinking about <ace/Reactor.h> in a test, didn't notice you only changed core files, not tests

jwillemsen avatar Dec 24 '20 07:12 jwillemsen