Djordje Nedic
Djordje Nedic
When writing to RAM, we need to check if we are overwriting the stub.
> The stub version would require the old baud rate as second parameter. > I've thought about adding a baudrate variable to > ```c > typedef struct { > uint32_t...
> Even with a compile time only switch you'd need to check if the stub is running for the RAM command. Unless I am missing something, if we always upload...
> When uploading the bootloader (mem* functions) you can't check for RAM being overwritten. Of course the stub loader gets written to the stub loader destination. So, even with a...
> Then the stub loader would require its own esp_loader_mem_start (and friends) functions. Currently I use it to upload the stub and those functions don't know if the stub is...
Overall, the PR seems in a solid state now, I will dedicate some time to test it on hardware. @radimkarnis If you have the time please take a look as...
I'm still not sure how we would handle the baudrate change command requirement when using the stub, breaking changes are not an option so we can't change the function itself....
I would not go that route personally for the following reasons: 1. This is a public API function and this would force people to understand a very esoteric language feature...
Thanks for rebasing on top of `master`! Please try disabling autoformatters/doing any manual formatting on code that's not part of the PR functionality. If something is inconsistent it can be...
> Any updates on when this might merge? I still haven't had the time to fully test this, but I should get around to it soon. After I test it...