PolyDeploy icon indicating copy to clipboard operation
PolyDeploy copied to clipboard

Removing the UseTaskFriendlySynchronizationContext key on uninstall breaks other modules

Open ghost opened this issue 7 years ago • 3 comments

Removing the aspnet:UseTaskFriendlySynchronizationContext key from the web.config on module uninstall breaks other modules installed on my DNN site that require the use of the key.

Can we just add the key on install if it's not already present in the web.config and then not remove it on uninstall. As there's no way to tell if it was already present / if anything else uses the key.

ghost avatar Feb 20 '18 10:02 ghost

Honestly, I rarely see this key ever used. What other modules do you see using this?

WillStrohl avatar Feb 21 '18 18:02 WillStrohl

We have used this key in several modules across several clients, its true that it is used rarely and would only cause a problem if PolyDeploy was uninstalled, however I think we should leave the key there by default.

StevenFisherCantarus avatar Mar 02 '18 14:03 StevenFisherCantarus

Since the installation instructions tell you to add the key yourself, I think it makes sense to remove it yourself too. Maybe there should be an uninstall guide along with the install guide.

Swimburger avatar Jun 05 '18 14:06 Swimburger