DNN.Feedback icon indicating copy to clipboard operation
DNN.Feedback copied to clipboard

C# Conversion

Open valadas opened this issue 7 years ago • 3 comments
trafficstars

Module should be converted to C# to be on the same language as all other modules and the platform too.

valadas avatar Sep 21 '18 21:09 valadas

DNN.Feedback_C.zip

If anyone has time to complete, here is my c# conversion of this module. I would say it is probably like 95% ok, I just think there are issues plugging the event handlers correctly, some fire up some don't. I put it in here just in case someone decides to continues on this, I ran out of time to work on that this week, so I just release 6.6.0 in VB, hopefully the next 7.0.0 version will be C#.

valadas avatar Sep 23 '18 18:09 valadas

Just a head up if someone tries to fix those issues. Adding the event in the view (ascx) does not appear to work correctly. So I added the events in the init stage of each codebehind file, for some reason some work some don't. Also, for some reason on some controls Init and/or Load fire up twice each time the control is displayde.

valadas avatar Sep 23 '18 18:09 valadas

So I'm all for C# and all, but I would say we just leave the module as VB? No real downsides, and wouldn't hurt to have a VB.net example module available....

ChrisHammond avatar May 05 '20 18:05 ChrisHammond